add init container when vpa recommender init from history provider

[cswangzheng]

We are using vertical-pod-autoscaler for autoscaler. We use prometheus as history data provider.
Got Error adding metric sample for container

There are two related issues found:
#2010
#2512

After checking, we found the ContainerState is not initialized before LoadPods of RunOnce method.
Due to InitFromHistoryProvider is before RunOnce in main loop, the feeder.clusterState.AddSample will always got fail. The history data will not be added to the ClusterState.

The solution is init container in InitFromHistoryProvider after init pod in ClusterState. Since the request of container is unknown, give a nil as param. The resource request will be updated to right value in the LoadPods in RunOnce of main loop.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @cswangzheng!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[cswangzheng]

I signed it

[sherifkayad]

Hi guys,

are there any updates to this one? should we expect that to be merged soon?

[cswangzheng]

Hi @jbartosik @krzysied, can you help review this change?

[krzysied]

/assign @bskiba

[cswangzheng]

Hi @bskiba, can you help review this change?

[cswangzheng]

Hi @krzysied, would you please check the answer to your comment?

[jbartosik]

/lgtm
/approve
I think this needs a test, I'll add some in #4296

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cswangzheng, jbartosik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS [jbartosik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chacond]

I am still getting "Error adding metric sample for container" in our logs.

• Running VPA 0.11
• Running EKS 1.21
• We use prometheus as history data provider

I was under the assumption the fix to this bug was present in v0.10

[jbartosik]

It is: 49992e7

[chacond]

@jbartosik Do you have any idea why this is popping up in v0.11 ?

[jbartosik]

No. If you'd like to discuss it please open an issue (& please link to this PR to make the conversation easier to follow)

[superset1]

I am still getting "Error adding metric sample for container" in our logs.

[jbartosik]

I am still getting "Error adding metric sample for container" in our logs.

Which VPA version are you using?

[jbartosik]

@superset1 @chacond

[alfsch]

vpa-recommender:1.1.2

│ W0823 13:25:58.916158       1 cluster_feeder.go:433] Error adding metric sample for container {{postgres-operator postgres-operator-58c4f8876d-59nmh} istio-proxy}: KeyError: {{postgres-operator postgres-operator-58c4f8876d-59nmh} istio-proxy}                                │
│ W0823 13:25:58.916170       1 cluster_feeder.go:433] Error adding metric sample for container {{postgres-operator postgres-operator-58c4f8876d-59nmh} istio-proxy}: KeyError: {{postgres-operator postgres-operator-58c4f8876d-59nmh} istio-proxy}                                │
│ W0823 13:25:58.916183       1 cluster_feeder.go:433] Error adding metric sample for container {{prometheus-operator prometheus-operator-grafana-f89549769-fxzmr} istio-proxy}: KeyError: {{prometheus-operator prometheus-operator-grafana-f89549769-fxzmr} istio-proxy}          │
│ W0823 13:25:58.916191       1 cluster_feeder.go:433] Error adding metric sample for container {{prometheus-operator prometheus-operator-grafana-f89549769-fxzmr} istio-proxy}: KeyError: {{prometheus-operator prometheus-operator-grafana-f89549769-fxzmr} istio-proxy}          │
│ W0823 13:25:58.916209       1 cluster_feeder.go:433] Error adding metric sample for container {{prometheus-operator prometheus-operator-kube-p-operator-58fdbb78fc-wp2dc} istio-proxy}: KeyError: {{prometheus-operator prometheus-operator-kube-p-operator-58fdbb78fc-wp2dc} ist │
│ W0823 13:25:58.916218       1 cluster_feeder.go:433] Error adding metric sample for container {{prometheus-operator prometheus-operator-kube-p-operator-58fdbb78fc-wp2dc} istio-proxy}: KeyError: {{prometheus-operator prometheus-operator-kube-p-operator-58fdbb78fc-wp2dc} ist │
│ W0823 13:25:58.916228       1 cluster_feeder.go:433] Error adding metric sample for container {{prometheus-operator prometheus-operator-kube-state-metrics-6d7cb9dc74-qhz6t} istio-proxy}: KeyError: {{prometheus-operator prometheus-operator-kube-state-metrics-6d7cb9dc74-qhz6 │
│ W0823 13:25:58.916236       1 cluster_feeder.go:433] Error adding metric sample for container {{prometheus-operator prometheus-operator-kube-state-metrics-6d7cb9dc74-qhz6t} istio-proxy}: KeyError: {{prometheus-operator prometheus-operator-kube-state-metrics-6d7cb9dc74-qhz6 │
│ W0823 13:25:58.916270       1 cluster_feeder.go:433] Error adding metric sample for container {{prometheus-operator prometheus-prometheus-operator-kube-p-prometheus-0} istio-proxy}: KeyError: {{prometheus-operator prometheus-prometheus-operator-kube-p-prometheus-0} istio-p │
│ W0823 13:25:58.916279       1 cluster_feeder.go:433] Error adding metric sample for container {{prometheus-operator prometheus-prometheus-operator-kube-p-prometheus-0} istio-proxy}: KeyError: {{prometheus-operator prometheus-prometheus-operator-kube-p-prometheus-0} istio-p │
│