Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick 3308 onto 1.19 - Fix priority expander falling back to random although higher priority matches #3958

Merged
merged 3 commits into from
May 17, 2021
Merged

Cherry pick 3308 onto 1.19 - Fix priority expander falling back to random although higher priority matches #3958

merged 3 commits into from
May 17, 2021

Conversation

nitrag
Copy link
Contributor

@nitrag nitrag commented Mar 19, 2021

Cherry pick #3308 onto 1.19

Attempt number 2 because #3582 only merged to master

k8s-ci-robot and others added 2 commits October 5, 2020 09:55
@k8s-ci-robot @nitrag
Merge pull request kubernetes#3308 from bruecktech/fix-fallback
0e4a077 
Fix priority expander falling back to random although higher priority matches
@nitrag
Revert version
6efff86
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 19, 2021
@nitrag
Copy link
Contributor Author

nitrag commented Mar 19, 2021

Thanks for finding @cablespaghetti

CC previous approver @mwielgus

@cablespaghetti cablespaghetti mentioned this pull request Mar 19, 2021
Closed
@cablespaghetti
Copy link
Contributor

Fixes #3956

mwielgus
mwielgus approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, nitrag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit b72efdf into kubernetes:cluster-autoscaler-release-1.19 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nitrag @cablespaghetti @k8s-ci-robot @mwielgus @jbartosik