Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make arch-specific releases use separate images instead of tags on the same image #3768

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

towca
Copy link
Collaborator

@towca towca commented Dec 15, 2020

This seems to be the current convention in k8s.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2020
@towca
Copy link
Collaborator Author

towca commented Dec 15, 2020

@hakman, you introduced arch-specific builds to the Makefile. Could you please take a look?
/assign @hakman

@hakman
Copy link
Member

hakman commented Dec 15, 2020

@towca In general this is true, but not sure if there is support support for pushing manifests using cross repo references. If you really want the -amd64 and -arm64 images pushed to the corresponding repos, may be safer to retag with the corresponding suffixed images.

If you look at what is actually pushed to the prod repo from staging, you will see that there are no tags for the -amd64 and -arm64 images, just the main one, so cleanup is done by the promoter.
https://console.cloud.google.com/gcr/images/k8s-artifacts-prod/EU/autoscaling/cluster-autoscaler

@towca
Copy link
Collaborator Author

towca commented Dec 15, 2020

The process of promoting images from staging to prod is completely manual. We haven't promoted any arch-specific cluster-autoscaler images yet. I want to promote an arm64 image right now, hence the changes. The promotion shouldn't be an issue, the same thing has already been done for Vertical Pod Autoscaler: kubernetes/k8s.io#1318.

Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified things a bit. My concern was that the push to staging won't work.
Also, if you want to push the ARM64 image in kubernetes/k8s.io#1485, you should also push the AMD64 one.

cluster-autoscaler/Makefile Outdated Show resolved Hide resolved
cluster-autoscaler/Makefile Show resolved Hide resolved
cluster-autoscaler/Makefile Show resolved Hide resolved
cluster-autoscaler/Makefile Show resolved Hide resolved
…e same image

This seems to be the current convention in k8s.
@towca towca force-pushed the jtuznik/makefile-arch branch from 8cf9158 to 5534fa4 Compare December 15, 2020 19:24
@towca
Copy link
Collaborator Author

towca commented Dec 15, 2020

I've already tested pushing to staging, so that shouldn't be a concern (gcr.io/k8s-staging-autoscaling/cluster-autoscaler-arm64:v1.20.0).

I'm building and promoting the arm64 image for a previous release specifically because somebody asked for it during the SIG meeting. All next releases will have all 3 images released. But sure, I can include the amd64 image as well.

@hakman
Copy link
Member

hakman commented Dec 15, 2020

Thanks. I tested this also and worked fine for me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020
@towca
Copy link
Collaborator Author

towca commented Dec 15, 2020

Thanks for the review!
/assign @MaciekPytel

@hakman
Copy link
Member

hakman commented Dec 15, 2020

Thanks for the releases @towca :)

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 04b2ae8 into kubernetes:master Dec 17, 2020
k8s-ci-robot added a commit that referenced this pull request Oct 1, 2021
Cluster Autoscaler: backport #3768 to 1.20
k8s-ci-robot added a commit that referenced this pull request Oct 1, 2021
Cluster Autoscaler: backport #3768 to 1.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants