-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make arch-specific releases use separate images instead of tags on the same image #3768
Conversation
@towca In general this is true, but not sure if there is support support for pushing manifests using cross repo references. If you really want the If you look at what is actually pushed to the prod repo from staging, you will see that there are no tags for the |
The process of promoting images from staging to prod is completely manual. We haven't promoted any arch-specific |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified things a bit. My concern was that the push to staging won't work.
Also, if you want to push the ARM64 image in kubernetes/k8s.io#1485, you should also push the AMD64 one.
…e same image This seems to be the current convention in k8s.
8cf9158
to
5534fa4
Compare
I've already tested pushing to staging, so that shouldn't be a concern (gcr.io/k8s-staging-autoscaling/cluster-autoscaler-arm64:v1.20.0). I'm building and promoting the arm64 image for a previous release specifically because somebody asked for it during the SIG meeting. All next releases will have all 3 images released. But sure, I can include the amd64 image as well. |
Thanks. I tested this also and worked fine for me. |
Thanks for the review! |
Thanks for the releases @towca :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mwielgus, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cluster Autoscaler: backport #3768 to 1.20
Cluster Autoscaler: backport #3768 to 1.19
This seems to be the current convention in k8s.