-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CA-1.19] CAPI backports for autoscaling workload clusters #3550
[CA-1.19] CAPI backports for autoscaling workload clusters #3550
Conversation
[cluster-autoscaler][clusterapi] Remove internal types in favor of unstructured
[cluster-autoscaler][clusterapi] Add support for node autodiscovery to clusterapi provider
[cluster-autoscaler] Support using --cloud-config for clusterapi provider
Update group identifier to use for Cluster API annotations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vendored kubernetes commit hash for main: 3eb90c1
vendored kubernetes commit hash for cluster-autoscaler-release-1.19: 23b66ea
The new additions to vendor will likely need to be modified to match the commit hash for the branch you are targeting.
In the past I've taken the following approach:
- find the temporary directory used for the branch you are backporting to in cluster-autoscaler/go.mod and create it locally
- find the correct commit hash, you can generally find this by looking at the commit history for the vendor directory, it should see commit messages similar to 'Updating vendor against [email protected]:kubernetes/kubernetes.git:master (commit hash)'
- merge/cherry-pick the changes
- checkout
cluster-autoscaler/vendor
from the current upstream commit - run cluster-autoscaler/hack/udpate-vendor.sh -d -r -r [email protected]:kubernetes/kubernetes.git
I think the three directory additions are correct:
|
/area provider/cluster-api |
/lgtm Thanks for tackling this @benmoss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Backports the recent work @detiber did to enable running the autoscaler against a different cluster than the one it is running in.
cc @elmiko