Use FitsAnyNode in binpacking #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that PreFilters are run once per pod in binpacking instead of #pods*#nodes times. This makes a huge performance difference in very large clusters.
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vivekbagade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
MaciekPytel
added a commit
to MaciekPytel/autoscaler
that referenced
this pull request
Sep 2, 2020
This is the scale-down equivalent of kubernetes#3429 and it speeds-up findUnneeded by 5x+ in very large clusters (by reducing the number of expensive PreFilter calls #nodes times). A side effect of this change is removing "Simulating scheduling of <pod> to <node> return error <error>" logs. Using FitsAny we no longer have per-node scheduler errors that we could log. I think that's actually a good thing - even with klogx this log was incredibly spammy in cluster with >100 nodes and its practical value was questionable.
Ladicle
pushed a commit
to Ladicle/autoscaler
that referenced
this pull request
Oct 12, 2020
This is the scale-down equivalent of kubernetes#3429 and it speeds-up findUnneeded by 5x+ in very large clusters (by reducing the number of expensive PreFilter calls #nodes times). A side effect of this change is removing "Simulating scheduling of <pod> to <node> return error <error>" logs. Using FitsAny we no longer have per-node scheduler errors that we could log. I think that's actually a good thing - even with klogx this log was incredibly spammy in cluster with >100 nodes and its practical value was questionable.
ghost
pushed a commit
to Capillary/autoscaler
that referenced
this pull request
Jan 28, 2021
This is the scale-down equivalent of kubernetes#3429 and it speeds-up findUnneeded by 5x+ in very large clusters (by reducing the number of expensive PreFilter calls #nodes times). A side effect of this change is removing "Simulating scheduling of <pod> to <node> return error <error>" logs. Using FitsAny we no longer have per-node scheduler errors that we could log. I think that's actually a good thing - even with klogx this log was incredibly spammy in cluster with >100 nodes and its practical value was questionable.
aksentyev
pushed a commit
to aksentyev/autoscaler
that referenced
this pull request
Apr 9, 2021
This is the scale-down equivalent of kubernetes#3429 and it speeds-up findUnneeded by 5x+ in very large clusters (by reducing the number of expensive PreFilter calls #nodes times). A side effect of this change is removing "Simulating scheduling of <pod> to <node> return error <error>" logs. Using FitsAny we no longer have per-node scheduler errors that we could log. I think that's actually a good thing - even with klogx this log was incredibly spammy in cluster with >100 nodes and its practical value was questionable.
This was referenced Apr 22, 2021
k8s-ci-robot
added a commit
that referenced
this pull request
May 17, 2021
Cherry-pick #3429 onto the 1.19 release - Use FitsAnyNode in binpacking
k8s-ci-robot
added a commit
that referenced
this pull request
May 17, 2021
Cherry pick #3429 onto 1.18 - Use FitsAnyNode in binpacking
piotrnosek
pushed a commit
to piotrnosek/autoscaler
that referenced
this pull request
Nov 30, 2021
This is the scale-down equivalent of kubernetes#3429 and it speeds-up findUnneeded by 5x+ in very large clusters (by reducing the number of expensive PreFilter calls #nodes times). A side effect of this change is removing "Simulating scheduling of <pod> to <node> return error <error>" logs. Using FitsAny we no longer have per-node scheduler errors that we could log. I think that's actually a good thing - even with klogx this log was incredibly spammy in cluster with >100 nodes and its practical value was questionable.
tim-smart
pushed a commit
to arisechurch/autoscaler
that referenced
this pull request
Nov 22, 2022
This is the scale-down equivalent of kubernetes#3429 and it speeds-up findUnneeded by 5x+ in very large clusters (by reducing the number of expensive PreFilter calls #nodes times). A side effect of this change is removing "Simulating scheduling of <pod> to <node> return error <error>" logs. Using FitsAny we no longer have per-node scheduler errors that we could log. I think that's actually a good thing - even with klogx this log was incredibly spammy in cluster with >100 nodes and its practical value was questionable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that PreFilters are run once per pod in binpacking
instead of #pods*#nodes times. This makes a huge performance
difference in very large clusters.