Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: Enrich unit tests for azure_cloud_provider #3307

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Azure: Enrich unit tests for azure_cloud_provider #3307

merged 1 commit into from
Jul 9, 2020

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Jul 9, 2020

Mirror: #3258

/area provider/azure
/priority important-soon
/kind cleanup

@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 9, 2020
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and marwanad July 9, 2020 06:27
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2020
@nilo19 nilo19 force-pushed the cleanup/enrich-cloudprovider-test branch from 5ab5655 to a648b93 Compare July 9, 2020 06:34
@nilo19 nilo19 force-pushed the cleanup/enrich-cloudprovider-test branch from a648b93 to 4decfcd Compare July 9, 2020 06:37
feiskyer
feiskyer reviewed Jul 9, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit c452eee into kubernetes:master Jul 9, 2020
@nilo19 nilo19 deleted the cleanup/enrich-cloudprovider-test branch July 9, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@marwanad marwanad Awaiting requested review from marwanad

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilo19 @k8s-ci-robot @feiskyer