Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.15: Fix bad cherry-pick from #3141 #3187

Merged
merged 2 commits into from
Jun 4, 2020
Merged

1.15: Fix bad cherry-pick from #3141 #3187

merged 2 commits into from
Jun 4, 2020

Conversation

marwanad
Copy link
Member

@marwanad marwanad commented Jun 3, 2020

1.17 and below are using the old clients not vendored from cloud-provider

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2020
@marwanad marwanad changed the title Fix bad cherry-pick from #3141 1.15: Fix bad cherry-pick from #3141 Jun 3, 2020
@marwanad
Copy link
Member Author

marwanad commented Jun 3, 2020

/area provider/azure

@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Jun 3, 2020
@marwanad
Copy link
Member Author

marwanad commented Jun 3, 2020 •
edited
Loading

CI status: https://travis-ci.org/github/kubernetes/autoscaler/jobs/694398849

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2020
@marwanad
Copy link
Member Author

marwanad commented Jun 3, 2020

Seems like Travis keeps insisting on running the VPA suite instead but I did a local run to verify the unit tests aren't failing.

feiskyer
feiskyer reviewed Jun 4, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit d52ce16 into kubernetes:cluster-autoscaler-release-1.15 Jun 4, 2020
@marwanad marwanad deleted the fix-bad-cherry-pick branch August 21, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@krzysztof-jastrzebski krzysztof-jastrzebski Awaiting requested review from krzysztof-jastrzebski

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marwanad @k8s-ci-robot @feiskyer