[CA-1.18] #3057 cherry-pick: CAPI: Do not normalize Node IDs outside of CAPI provider

[detiber]

his PR proposes to backport #3057 to the cluster-autoscaler-release-1.18 branch.

From original PR:

When #1866 introduced the CAPI provider, all Provider IDs from nodes were being normalized so that internally, there were no differences (eg some places using normalized, some not)

However, the clusterstateregistry and anything outside of the CPAI provider does not expect the instance IDs to be normalized, and so nodes were being marked as unregistered due to the normalized ID not matching the non-normalized ID coming from the Nodes on the cluster.

This PR makes it so that Instance IDs fetched and passed externally are not normalized, fixing the unregistered node logic in the clusterstateregistry when using the CAPI provider.

[detiber]

/hold
should not be merged before #3171 and #3172

[detiber]

Includes both #3171 and #3172 currently

[detiber]

/area provider/cluster-api

[detiber]

/assign @elmiko

[elmiko]

thanks Jason!
/approve

[detiber]

/hold cancel

This should be good to go now that the pre-requisite PRs have merged and this has been rebased.

[detiber]

/assign @enxebre

[enxebre]

/approve

[enxebre]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/clusterapi/OWNERS [elmiko,enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment