Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync e2e_test file with k/k master #2580

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Conversation

bskiba
Copy link
Member

@bskiba bskiba commented Nov 27, 2019

Without this change test flags are not registered and this fails with go1.13

Also reinstate the timeout

Without this change test flags are not registered and this fails with go
1.13
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 27, 2019
@bskiba
Copy link
Member Author

bskiba commented Nov 27, 2019

/approve

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2019
@bskiba bskiba added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 74c9229 into kubernetes:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants