Fix a bug in initializing scheduler #2565
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm /approve |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
I tested this using pods with hostport conflict - without this CA won't scale for them, because it lacks relevant predicate and thinks those are schedulable. With this change the scale-up happens as expected. |
| @@ -125,6 +125,7 @@ func NewPredicateChecker(kubeClient kube_client.Interface, stop <-chan struct{}) | |||
| NoOpEventRecorder{}, | |||
| stop, | |||
| scheduler.WithAlgorithmSource(algorithmSource), | |||
| scheduler.WithFrameworkConfigProducerRegistry(nil), | |||
There was a problem hiding this comment.
you can remove line 127 above, by default the scheduler uses "schedulerconfig.SchedulerDefaultProviderName"
There was a problem hiding this comment.
That's a fair point. I was wondering if we're better off not relying on default, but assuming that by default we'll get a DefaultProvider seems reasonable.
By default scheduler now returns plugins instead of predicates. However, plugins are not yet supported by CA, so we need to make scheduler return predicates.
MaciekPytel
force-pushed
the
fix_predicates
branch
from
0f1dad0 to
2113e06
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaciekPytel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
By default scheduler now returns plugins instead of predicates.
However, plugins are not yet supported by CA, so we need to make
scheduler return predicates.