Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running e2e tests for VPA #2553

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Fix running e2e tests for VPA #2553

merged 2 commits into from
Nov 22, 2019

Conversation

bskiba
Copy link
Member

@bskiba bskiba commented Nov 22, 2019

This is a hack as it breaks deps management with go mod.

  1. I forced inclusion of autogenerated data (running hack/generate-bindata.sh in k/k repo)
  2. I'm trying to figure out how the modules work with test dependencies.

I'll be working on having a better schema for deps management in VPA e2e.

@bskiba
Fix running e2e tests.
2d5c9e3 
Use vendor directory to run tests, since we rely on generated data.
@bskiba
Run go mod vendor
8467798
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 22, 2019
@bskiba
Copy link
Member Author

bskiba commented Nov 22, 2019

/approve

@bskiba bskiba added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8024e2d into kubernetes:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbartosik jbartosik Awaiting requested review from jbartosik

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bskiba @k8s-ci-robot