Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] VPA: update go modules #2530

Closed
wants to merge 1 commit into from
Closed

[WIP] VPA: update go modules #2530

wants to merge 1 commit into from

Conversation

wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented Nov 13, 2019 •
edited
Loading

Effort to simplify go modules tracking removing the requirement for replace directives with filesystem absolute paths.

If possible, downstream projects would prefer something along the lines of #2531 to remove dependency on k8s.io/kubernetes

Closes: #2507

TODO:

  • add script to handle modules automatically

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jbartosik
You can assign the PR to them by writing /assign @jbartosik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wozniakjan wozniakjan changed the title [WIP] Update go modules [WIP] VPA: update go modules Nov 13, 2019
@wozniakjan wozniakjan mentioned this pull request Nov 13, 2019
Merged
@wozniakjan
Copy link
Member Author

closing in favor of #2531

@wozniakjan wozniakjan closed this Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bskiba bskiba Awaiting requested review from bskiba

@jbartosik jbartosik Awaiting requested review from jbartosik

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VPA: go modules reference local files
2 participants
@wozniakjan @k8s-ci-robot