Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] minor documentation fixes #2482

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

jaypipes
Copy link
Contributor

A few minor fixes for the AWS cloud provider documentation:

  • corrects a mistake in where the mixed instance policy example section appears
  • rework the docs around IAM policy to simplify and clean it up

The example for using MixedInstancePolicy was accidentally placed under
the new section of the docs for using static instance types, instead of
its correct location under the MixedInstancePolicy section.
Cleans up the documentation regarding the IAM policy permissions that
need to be added for cluster autoscaler to work properly, depending on
the features desired.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 24, 2019
@jaypipes
Copy link
Contributor Author

/assign @Jeffwan
/area provider/aws

@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Oct 24, 2019
@k8s-ci-robot k8s-ci-robot requested review from Jeffwan and piosz October 24, 2019 23:07
@Jeffwan
Copy link
Contributor

Jeffwan commented Oct 25, 2019

/lgtm
/approve

Great!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8337753 into kubernetes:master Oct 25, 2019
@jaypipes jaypipes deleted the rework-aws-readme branch December 11, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants