Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws] use simple string prefix placeholder match #2480

Merged
merged 1 commit into from
Oct 28, 2019
Merged

[aws] use simple string prefix placeholder match #2480

merged 1 commit into from
Oct 28, 2019

Conversation

jaypipes
Copy link
Contributor

Addresses a comment on PR2235
to remove the unnecessary use of a regex with a simpler string prefix
matching for placeholder names.

@jaypipes
[aws] use simple string prefix placeholder match
72f936e 
Addresses a [comment on PR2235](https://github.com/kubernetes/autoscaler/pull/2235/files#r313536379)
to remove the unnecessary use of a regex with a simpler string prefix
matching for placeholder names.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2019
@Jeffwan
Copy link
Contributor

Jeffwan commented Oct 28, 2019

/cc @seh @gjtempleton

As you either changed or left comments on placeholder regex, please help review.

@k8s-ci-robot
Copy link
Contributor

@Jeffwan: GitHub didn't allow me to request PR reviews from the following users: seh.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @seh @gjtempleton

As you either changed or left comments on placeholder regex, please help review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gjtempleton
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2019
@Jeffwan
Copy link
Contributor

Jeffwan commented Oct 28, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit e536639 into kubernetes:master Oct 28, 2019
@jaypipes jaypipes deleted the rework-placeholder-match branch December 11, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjtempleton gjtempleton gjtempleton approved these changes

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

@losipiuk losipiuk Awaiting requested review from losipiuk

Assignees

@gjtempleton gjtempleton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaypipes @Jeffwan @k8s-ci-robot @gjtempleton