-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract separate package for core/utils.go and split into multiple files. #2407
Extract separate package for core/utils.go and split into multiple files. #2407
Conversation
77eaf9c
to
d4cc12d
Compare
d4cc12d
to
7f083d2
Compare
|
||
var ( | ||
// NodeConditionTaints lists taint keys used as node conditions | ||
NodeConditionTaints = TaintKeySet{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: does it need to be exported? It's never used outside the package
Two thoughts (non-blocking):
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleksandra-malinowska The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR extracts uitls.go from core package to separate utils package. The motivation for that is the size of core package. Is humongous which hinders maintenance. Expect subsequent refactors in the area.