Don't attempt to delete aggregation from VPA if it doesn't exist #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/retest The failure looks not related to the change: $ sudo apt-get install libseccomp-dev -qq
479E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/libs/libseccomp/libseccomp2_2.1.1-1ubuntu1~trusty5_amd64.deb Could not connect to apt.cache.travis-ci.com:80 (34.96.81.152), connection timed out
480
481E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/libs/libseccomp/libseccomp-dev_2.1.1-1ubuntu1~trusty5_amd64.deb Unable to connect to apt.cache.travis-ci.com:http:
482
483E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
484The command "sudo apt-get install libseccomp-dev -qq" failed and exited with 100 during . |
|
/assign @bskiba |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskiba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw VPA failing in that MarkNotAutoscaled because it was accessing nil.I think it's when it tires to clean up aggregation from key for which there is no aggregation yet.