-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cronjobs in VPA #2195
Conversation
In general /lgtm. Do you think Cron Jobs are worth adding e2e test? |
I was thinking about adding e2e. Currently we only have almost all tests with VPA on Deployment, the only ones where we exercise different controllers is updater (Evicts pods in ...). I came to a conclusion that it makes little sense to evict pods from a CronJob. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskiba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Would it be possible for the VPA to make its recommendations so that the next time the job is run it uses the recommendations? |
Yes, once this releases, if you set VPA on CronJob and updateMode: Initial, each new launched Job will get request based on recommendations calculated from previous jobs usage. Note, this will not work well with short lived jobs (<1minute). |
@bskiba is there any timeline when this is going to be released? |
Fixes #1790