Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cronjobs in VPA #2195

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Conversation

bskiba
Copy link
Member

@bskiba bskiba commented Jul 17, 2019

Fixes #1790

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2019
@bskiba
Copy link
Member Author

bskiba commented Jul 17, 2019

@schylek

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 17, 2019
@schylek
Copy link
Contributor

schylek commented Jul 18, 2019

In general /lgtm. Do you think Cron Jobs are worth adding e2e test?

@bskiba
Copy link
Member Author

bskiba commented Jul 18, 2019

I was thinking about adding e2e. Currently we only have almost all tests with VPA on Deployment, the only ones where we exercise different controllers is updater (Evicts pods in ...). I came to a conclusion that it makes little sense to evict pods from a CronJob.
However it would be nice to have a "VPA provides recommendations" scenario for all the known controllers.

@bskiba bskiba added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2019
@bskiba
Copy link
Member Author

bskiba commented Jul 18, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5ce7457 into kubernetes:master Jul 18, 2019
@mcfedr
Copy link

mcfedr commented Jul 18, 2019

Would it be possible for the VPA to make its recommendations so that the next time the job is run it uses the recommendations?

@bskiba
Copy link
Member Author

bskiba commented Jul 18, 2019

Yes, once this releases, if you set VPA on CronJob and updateMode: Initial, each new launched Job will get request based on recommendations calculated from previous jobs usage.

Note, this will not work well with short lived jobs (<1minute).

@johanneswuerbach
Copy link
Contributor

@bskiba is there any timeline when this is going to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPA for CronJob
5 participants