Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test case for controller_fetcher and cluster_feeder #2187

Merged
merged 1 commit into from
Jul 17, 2019
Merged

add test case for controller_fetcher and cluster_feeder #2187

merged 1 commit into from
Jul 17, 2019

Conversation

Moriadry-zz
Copy link

to raise code coverage of controller_fetcher and cluster_feeder.

@k8s-ci-robot
Copy link
Contributor

Welcome @moriadry!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2019
@k8s-ci-robot k8s-ci-robot requested review from bskiba and jbartosik July 14, 2019 06:31
@Moriadry-zz
Copy link
Author

/assign @jbartosik

@Moriadry-zz
Copy link
Author

@bskiba can you help me check this? This is my very start of k8s, thx!

bskiba
bskiba reviewed Jul 16, 2019
View reviewed changes
Copy link
Member

@bskiba bskiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the community! Thanks for the contribution :)

I have two comments.

vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder_test.go Show resolved Hide resolved
vertical-pod-autoscaler/pkg/recommender/input/controller_fetcher/controller_fetcher_test.go Outdated Show resolved Hide resolved
@bskiba bskiba assigned bskiba and unassigned jbartosik Jul 16, 2019
@bskiba
Copy link
Member

bskiba commented Jul 16, 2019

Looks good! Can you please squash to one commit and we're good to submit.

@moriadry
add test case for controller_fetcher and cluster_feeder
7f644ab 
add test case for controller_fetcher
correct comments
typo
@Moriadry-zz Moriadry-zz force-pushed the feature/coverage_input branch from 36bc592 to 7f644ab Compare July 16, 2019 16:34
@Moriadry-zz
Copy link
Author

@bskiba done.

@bskiba
Copy link
Member

bskiba commented Jul 17, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit b5cf26e into kubernetes:master Jul 17, 2019
@Moriadry-zz Moriadry-zz deleted the feature/coverage_input branch July 17, 2019 08:01
@Moriadry-zz Moriadry-zz mentioned this pull request Aug 8, 2019
Closed
6 tasks
@danielmellado danielmellado mentioned this pull request Oct 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bskiba bskiba bskiba left review comments

@jbartosik jbartosik Awaiting requested review from jbartosik

Assignees

@bskiba bskiba

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Moriadry-zz @k8s-ci-robot @bskiba @jbartosik @moriadry