Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raises request according to pod min limit set in LimitRange test #2100

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

jbartosik
Copy link
Collaborator

Admisson controller was crashing because it was tryig to divide by 0 so
it dind't make any changes to pod.

Adter I fixed that only 1 pod would fit in the cluster so I lowered
recommendation.

Admisson controller was crashing because it was tryig to divide by 0 so
it dind't make any changes to pod.

Adter I fixed that only 1 pod would fit in the cluster so I lowered
recommendation.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 6, 2019
@jbartosik
Copy link
Collaborator Author

/assign @bskiba

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 6, 2019
@k8s-ci-robot k8s-ci-robot requested review from bskiba and mwielgus June 6, 2019 14:53
@bskiba
Copy link
Member

bskiba commented Jun 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7d400e0 into kubernetes:master Jun 6, 2019
@jbartosik jbartosik deleted the pod-limit-range-e2e branch June 7, 2019 11:25
This was referenced Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants