Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple limitrange items #2073

Merged
merged 1 commit into from
May 30, 2019
Merged

Support multiple limitrange items #2073

merged 1 commit into from
May 30, 2019

Conversation

bskiba
Copy link
Member

@bskiba bskiba commented May 30, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 30, 2019
@bskiba bskiba requested a review from jbartosik May 30, 2019 08:49
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 30, 2019
@bskiba bskiba changed the title Support multiple limitrange items [WIP] Support multiple limitrange items May 30, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2019
@bskiba bskiba changed the title [WIP] Support multiple limitrange items Support multiple limitrange items May 30, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2019
@bskiba
Copy link
Member Author

bskiba commented May 30, 2019

@jbartosik ready for review

jbartosik
jbartosik reviewed May 30, 2019
View reviewed changes
vertical-pod-autoscaler/pkg/utils/limitrange/limit_range_calculator_test.go Outdated
baseContainerLimitRange := test.LimitRange().WithName("test-lr").WithNamespace(testNamespace).WithType(apiv1.LimitTypeContainer)
containerLimitRangeWithMax := baseContainerLimitRange.WithMax(test.Resources("2", "2")).Get()
containerLimitRangeWithDefault := baseContainerLimitRange.WithDefault(test.Resources("2", "2")).Get()
containerLimitRangeWithMin := baseContainerLimitRange.WithMax(test.Resources("2", "2")).Get()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is ..WithMin but it only has Max.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you.

vertical-pod-autoscaler/pkg/utils/limitrange/limit_range_calculator.go Outdated
return result
}
maxComparator := func(q1, q2 resource.Quantity) bool { return q1.Cmp(q2) > 0 }
minComparator := func(q1, q2 resource.Quantity) bool { return q1.Cmp(q2) < 0 }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial impression was that those do exact opposite of what they do. Maybe rename compactor returning bool to value picker that returns new value (if both are present)? It will be a little longer but easier to understand.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought this might be confusing. Changed.

jbartosik
jbartosik approved these changes May 30, 2019
View reviewed changes
Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@bskiba
Copy link
Member Author

bskiba commented May 30, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1b6184d into kubernetes:master May 30, 2019
This was referenced Jun 7, 2019
Merged
Merged
@danielmellado danielmellado mentioned this pull request Oct 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbartosik jbartosik jbartosik approved these changes

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@jbartosik jbartosik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bskiba @k8s-ci-robot @jbartosik