UPSTREAM: <carry>: fix max cluster size calculation on scale up #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scaling up the calculation for computing the maximum cluster size does not take into account the number of any upcoming nodes and it is possible to grow the cluster beyond the cluster size (--max-nodes-total). Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1670695
k8s-ci-robot
added
cncf-cla: yes
bskiba
requested review from
MaciekPytel and
aleksandra-malinowska
and removed request for
feiskyer and
piosz
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleksandra-malinowska The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
frobware
added a commit
to frobware/cluster-api-actuator-pkg
that referenced
this pull request
Jun 5, 2019
The previous behaviour was to scale out by waiting for the expected scale up events to be generated on the node groups. After that had completed we then waited for a further 60s to ensure that there were no further scale up attempts as we had explicitly capped the cluster size. This commit changes the behaviour from waiting for 60s to explicitly waiting for the MaxNodesTotalReached event to be generated. We use that event to assert that the cluster will not grow beyond the specified maximum. This PR also helps to validate that we carry two upstream fixes that were made with respect to calculating when the maximum size of the cluster is reached: - kubernetes/autoscaler#1516 - kubernetes/autoscaler#1771
frobware
added a commit
to frobware/cluster-api-actuator-pkg
that referenced
this pull request
Jun 14, 2019
The previous behaviour was to scale out by waiting for the expected scale up events to be generated on the node groups. After that had completed we then waited for a further 60s to ensure that there were no further scale up attempts as we had explicitly capped the cluster size. This commit changes the behaviour from waiting for 60s to explicitly waiting for the MaxNodesTotalReached event to be generated. We use that event to assert that the cluster will not grow beyond the specified maximum. This PR also helps to validate that we carry two upstream fixes that were made with respect to calculating when the maximum size of the cluster is reached: - kubernetes/autoscaler#1516 - kubernetes/autoscaler#1771
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scaling up the calculation for computing the maximum cluster size
does not take into account the number of any upcoming nodes and it is
possible to grow the cluster beyond the cluster
size (--max-nodes-total).
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1670695
See also: 5bc77f0