Improve AWS "gotchas" list and discoverability of cloud-provider READMEs. #1746
Conversation
…coverable #1744 Signed-off-by: Sam Weston <[email protected]>
Signed-off-by: Sam Weston <[email protected]>
Signed-off-by: Sam Weston <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
Thank you for this change! I wonder now, this is about multi-zone ASGs, right? Wasn't our answer that Cluster Autoscaler shouldn't be used at all with ASGs spanning multiple zones, as it expects to have homogeneous node-groups to scale and you should always do what is described in third bullet - use an ASG per zone? |
|
I should probably change my setup to use multiple ASGs then and update the PR. |
Signed-off-by: Sam Weston <[email protected]>
|
Hopefully this better encourages recommended practice whilst still explaining what's going on to people with the same issue as me. /assign @aleksandra-malinowska |
| @@ -142,8 +142,8 @@ If you'd like to scale node groups from 0, an `autoscaling:DescribeLaunchConfigu | |||
| ``` | |||
|
|
|||
| ## Common Notes and Gotchas: | |||
| - The `/etc/ssl/certs/ca-certificates.crt` should exist by default on your ec2 instance. If you use Amazon Linux 2 (EKS woker node AMI by default), use `/etc/ssl/certs/ca-bundle.crt` instead. | |||
| - Cluster autoscaler is not zone aware (for now), so if you wish to span multiple availability zones in your autoscaling groups beware that cluster autoscaler will not evenly distribute them. For more information, see https://github.com/kubernetes/contrib/pull/1552#discussion_r75532949. | |||
| - The `/etc/ssl/certs/ca-certificates.crt` should exist by default on your ec2 instance. If you use Amazon Linux 2 (EKS worker node AMI by default), use `/etc/kubernetes/pki/ca.crt` instead for the volume hostPath of your cluster-autoscaler manifest. | |||
There was a problem hiding this comment.
nit: "instead of the volume hostPath of your cluster-autoscaler manifest"
|
This looks great, thank you. One nit. |
Signed-off-by: Sam Weston <[email protected]>
|
Hopefully that makes a little more sense.
…On Tue, 5 Mar 2019 at 11:23, Beata Skiba ***@***.***> wrote:
This looks great, thank you. One nit.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1746 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKoi5qW4fGl9OymI9I1_WM8b0qQMWTrJks5vTlO-gaJpZM4bcKYm>
.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskiba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
* Don't deploy visibility by default * Review Remarks * Review Remarks * Review Remarks
Better document the caveats of running a multi-az autoscaling group with the cluster autoscaler on AWS. Also help people find the cloud provider specific documentation rather than just the FAQ.
Fixes #1744.