Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPA switches to 0.4.0 #1712

Merged
merged 1 commit into from
Feb 22, 2019
Merged

VPA switches to 0.4.0 #1712

merged 1 commit into from
Feb 22, 2019

Conversation

bskiba
Copy link
Member

@bskiba bskiba commented Feb 22, 2019

Change default version
Update docs

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2019
@bskiba
Copy link
Member Author

bskiba commented Feb 22, 2019

@kgolab @schylek

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 22, 2019
@Rajat-0
Copy link
Contributor

Rajat-0 commented Feb 22, 2019

lgtm

mwielgus
mwielgus approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2019
Rajat-0
Rajat-0 reviewed Feb 22, 2019
View reviewed changes
vertical-pod-autoscaler/README.md Outdated
# Installation

### Notice on switching from alpha to beta (<0.3.0 to >=0.3.0)
The current default version is Verical Pod Autoscaler 0.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:Vertical

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mwielgus
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2019
schylek
schylek reviewed Feb 22, 2019
View reviewed changes
vertical-pod-autoscaler/README.md Show resolved Hide resolved
vertical-pod-autoscaler/examples/hamster.yaml Outdated Show resolved Hide resolved
vertical-pod-autoscaler/README.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2019
@bskiba
VPA switches to 0.4.0
6720c08 
Change default version
Update docs
@bskiba
Copy link
Member Author

bskiba commented Feb 22, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2019
@mwielgus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit cfb76b7 into kubernetes:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajat-0 Rajat-0 Rajat-0 left review comments

@schylek schylek schylek left review comments

@kgolab kgolab kgolab left review comments

@mwielgus mwielgus mwielgus approved these changes

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bskiba @Rajat-0 @k8s-ci-robot @mwielgus @kgolab @schylek