VPA: Remove TLS client cert lookup logic #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
realdimas
changed the title
|
cc: @schylek |
|
Doesn't compile. Please fix. |
Actual verification is already turned off in the code and appears to be just a no-op. Moreover, VPA Admission Controller (acting as TLS Server) does not request client (apiserver, acting as TLS Client) to present certificate. This code is fragile, depends on apiserver having requestheader-client-ca-file certificate generated and supplied, and most importantly does not add any security or any other value.
|
@mwielgus, thanks, cleaned up unused imports. |
|
@tkulczynski - I believe you are the one who implemented this. Could you please take a look at the PR? Is this code needed? |
|
cc: @jbartosik |
|
I'll take a look later today. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks @jbartosik! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskiba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
realdimas
deleted the
clean-up-client-cert-lookup-code-in-vpa-admission-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual verification was turned off from the initial commit and is still not enabled, so the whole construct does not add value.
Also depending on
requestheader-client-ca-fileby itself renders VPA incompatible with apiserver installations which does not use such certificate with VPA Admission Controller crash-looping with:vpa-admission-controller-X-Y:admission-controller F0214 18:15:09.448204 9 config.go:60] cannot find the ca.crt in the configmap, configMap.Data is map[string]string{"client-ca-file":"...skipped..."}In addition to the above it worth noting that
requestheader-client-ca-fileappears to be just a wrong place to look for possible apiserver client certificate (I don't think there is any).