Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tainting nodes - update first, refresh on conflict #1598

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Tainting nodes - update first, refresh on conflict #1598

merged 1 commit into from
Jan 24, 2019

Conversation

jkaniuk
Copy link
Contributor

@jkaniuk jkaniuk commented Jan 21, 2019

Depend on #1587

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2019
@jkaniuk
Copy link
Contributor Author

jkaniuk commented Jan 21, 2019

/assign @losipiuk
/assign @aleksandra-malinowska
/assign @MaciekPytel

Please review only last commit but do not merge as it depend on other PR
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2019
@jkaniuk jkaniuk mentioned this pull request Jan 22, 2019
Merged
losipiuk
losipiuk reviewed Jan 22, 2019
View reviewed changes
Copy link
Contributor

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 24, 2019
@jkaniuk
Copy link
Contributor Author

jkaniuk commented Jan 24, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2019
@losipiuk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0a82f0e into kubernetes:master Jan 24, 2019
@jkaniuk jkaniuk deleted the update-before-get branch March 22, 2019 16:47
yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this pull request Feb 22, 2024
@astefanutti
Set default leader election configuration (kubernetes#1598)
94ec795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losipiuk losipiuk losipiuk left review comments

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

Assignees

@losipiuk losipiuk

@aleksandra-malinowska aleksandra-malinowska

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkaniuk @losipiuk @k8s-ci-robot @aleksandra-malinowska @MaciekPytel