-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify vendor code in presubmit #6267
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Hi @sophieliu15, JFI we removed the Cluster Autoscaler vendor directory in favor of Go modules, |
Closing this issue, as it is resolved by the PR #6572 |
@Shubham82: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Which component are you using?: VPA
Which component hosted in this repository is this a feature for?: All components
Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
Currently there is no good way to verify the integrity of modules under
vendor
directory. For example, someone could upgrade go version or go module version; update dependencies; performgo mod vendor
; hand edit a go file undervendor
and add a new function. The tempered vendor file will be buried in all the vendor changes.You could look at all the vendor file change and verify individually but it is pretty time consuming and unrealistic.
Describe the solution you'd like.: Add a verification under
hack/
directory to verify vendor code integrity. Similar to https://github.com/kubernetes/kubernetes/blob/master/hack/verify-vendor.shDescribe any alternative solutions you've considered.: Ideally
go mod verify
should do this but it is not happening: golang/go#27348Additional context.:
The text was updated successfully, but these errors were encountered: