Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure unittest failing on master #4592

Closed
MaciekPytel opened this issue Jan 11, 2022 · 7 comments
Closed

Azure unittest failing on master #4592

MaciekPytel opened this issue Jan 11, 2022 · 7 comments
Labels
area/cluster-autoscaler kind/bug Categorizes issue or PR as related to a bug.

Comments

@MaciekPytel
Copy link
Contributor

This is also causing unittest runs to fail on PRs. Example: https://github.com/kubernetes/autoscaler/runs/4767923107?check_suite_focus=true

The issue can be reliably reproduced by running make test-in-docker locally.

@feiskyer @marwanad @nilo19

@nilo19
Copy link
Member

nilo19 commented Jan 12, 2022

fixed by: #4594

@feiskyer
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@feiskyer: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaciekPytel
Copy link
Contributor Author

It seems the test got fixed for a second by #4594, but it's failing again now. Can we temporarily disable the test until it's fixed?

#4600 (comment) suggests there is some external endpoint the test depends on, can we consider some extra mocking to remove any external dependencies?

@MaciekPytel
Copy link
Contributor Author

Seems #4620 has fixed the test again, but I think it's bad practice for a unittest to make calls to an external API. Can we consider adding additional mocking to avoid doing that? @nilo19

@marwanad
Copy link
Member

/close

unit test removed/

@k8s-ci-robot
Copy link
Contributor

@marwanad: Closing this issue.

In response to this:

/close

unit test removed/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants