support AWS "Instance type requirements"

[garrygerber]

Which component are you using?:

Cluster-Autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

AWS added a new way of specifying instance types wanted.
they do this by specifying a set of instance characteristics - requirements.
which obsolete the need of specifying instance types, and in turn, breaks the CA when fetching the ASG info

Describe the solution you'd like.:

CA needs to support not knowing which instance type is used by the ASG

Describe any alternative solutions you've considered.:

CA will reed all the instance requirements from the ASG and calculate which instance type ASG will use when needed

Additional context.:

using CA v1.22.1 , error is:
E1128 15:47:36.224041 1 static_autoscaler.go:286] Failed to get node infos for groups: ASG "......." uses the unknown EC2 instance type ""

new settings in console looks:

[gjtempleton]

/area provider/aws

Hey, thanks for the suggestion. When raising feature requests like this, it helps us a huge amount if you fill out the answers to the questions in the feature request issue template including linking to any relevant external documentation.

[garrygerber]

Hey @gjtempleton, it would help a lot if you can point me to the lines of code that handle the following logics:

• request for Auto Scaling Group details
• calculation of required resources and scaling the ASG accordingly

Thanks!

[AustinSiu]

@garrygerber thank you for opening the issue! I've submitted a PR to help address this issue.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[garrygerber]

/reopen

[k8s-ci-robot]

@garrygerber: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eptiger]

Good news @garrygerber - a PR was just accepted a few days ago for supporting Instance Requirements: fed54b5