Provide option to balance label based on the given labels

[tsunny]

It would be nice to have a flag that could be passed to the autoscaler to chose the flags to compare the nodes if they are same.

This request would be the opposite of https://github.com/kubernetes/autoscaler/pull/2493.

At the moment, in our project we are passing a lot of labels to this flag to be ignored. This can be simplified by passing in the opt-in labels vs exclude labels using a different flag say, --balancing-node-labels

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[grosser]

/lifecycle frozen

[MaciekPytel]

If anyone wants to give this a go, I think it could be implemented fairly easily as a new comparator for BalancingNodeGroupSetProcessor.

[rtnpro]

I have started working to implement this feature.

[BLasan]

@jbartosik Is this still valid? If so I would like to assign my self for this issue

[BLasan]

/assign

[rtnpro]

+1 Go ahead.

On Sun, 10 Oct 2021 at 10:50 AM, Benura Abeywardena < ***@***.***> wrote: @jbartosik <https://github.com/jbartosik> Is this still valid? If so I would like to assign my self for this issue — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3615 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABYSBF3WOS45VDC24F2AUTUGEPAZANCNFSM4SRQTALQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Ratnadeep Debnath, https://www.waartaa.com GPG Fingerprint: A937 6DB0 91A2 3809 27B2 1C85 8145 B6DD 3CE6 14AC

[BLasan]

+1 Go ahead.
On Sun, 10 Oct 2021 at 10:50 AM, Benura Abeywardena < @.***> wrote: @jbartosik https://github.com/jbartosik Is this still valid? If so I would like to assign my self for this issue — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3615 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYSBF3WOS45VDC24F2AUTUGEPAZANCNFSM4SRQTALQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Ratnadeep Debnath, https://www.waartaa.com GPG Fingerprint: A937 6DB0 91A2 3809 27B2 1C85 8145 B6DD 3CE6 14AC

Can you elaborate this feature a bit more? I'm new to this project

[Ab-hishek]

@BLasan If this is not being worked upon, I would like to give it a shot.

[Ab-hishek]

/assign

[grosser]

this is done and should be closed

[Shubham82]

closing this as this is done in the PR #4174

[Shubham82]

/close

[k8s-ci-robot]

@Shubham82: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.