-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS: Failed to look for node info on ASG Launch Template #1754
Comments
/assign @Jeffwan |
@lcasassa Seems this PR #1053 did not merged into 1.3.x branch. In v1.12, LaunchTemplate is supported, so I would suggest you to use newer image. This change will be hard to cherry-pick now. Since you use Kubernetes is v1.11.x, should be fine to run with CA v1.12. However, it's always get into some situation not expect. If you meet any problems on eks, just let me know. autoscaler/cluster-autoscaler/cloudprovider/aws/aws_manager.go Lines 215 to 223 in 841c8a1
|
Thanks Jiaxin.
Looks like CA v1.12.2 (14 Jan) does not include the fix for
#1650 that was merged on 11
Feb in #1656 . I upgraded
because I am hitting this issue.
…On Wed, Mar 6, 2019 at 11:10 PM Jiaxin Shan ***@***.***> wrote:
/aws
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1754 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQMsc_O7yjFLwIV4alF0cqrAZ2IZaO_ks5vUErJgaJpZM4bg3hD>
.
--
Linus Casassa
+44 7393 771 568
|
@lcasassa Sure. If something is missing and you want to cherry-pick, feel free to submit PR or let us know, we can also help on that. |
Cool, I will give it a try
…On Thu, Mar 7, 2019, 7:33 AM Jiaxin Shan ***@***.***> wrote:
@lcasassa <https://github.com/lcasassa> Sure. If something is missing and
you want to cherry-pick. Feel free to submit PR or letting us know, we can
also help on that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1754 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQMsQVbbaiXX9WL_pQdDtNKxNgrsF0Rks5vUMDCgaJpZM4bg3hD>
.
|
/sig aws |
@Jeffwan Just FYI I use 4 instance types but they have same count of CPU cores but not memory. I use the following types why does the CA need to care about instance types instead of just adjusting the Desired Capacity of ASG regardless of instance types? EDIT: |
You don't have to limit to 1.3.x. Even thought compatibility test is not done for higher CA version, based on my experience, v1.12 shoud also work for Kubernetes v1.11.x
Without instance type information, CA doesn't know right number of nodes to bring up.
You want to use diversity instance types in one ASG or single instance type per ASG? |
I'm seeing this issue on K8 1.12 and 1.14 clusters with CA version 1.12.x and 1.14.x respectively. |
Let me have a test on these versions and have a patch. @CAR6807 Thanks for reporting. |
@CAR6807. The PR for Launch Template support has been merged from v1.12 and later versions. Could you share more details about your setups? Attaching error messages would be super helpful |
@Jeffwan - Is this on the backlog anywhere? |
@JasonCarter80 Not yet. This is against current CA single instance type per node group structure. We are still evaluating mix instance type support and make sure we can better fit into CA. Do you have any use cases? I'd love to hear more requirements which will give enough datapoints for next iteration |
|
@JasonCarter80 |
@Jeffwan Is there any way to do this today, perhaps via #1656 ? Our use case is the same as @JasonCarter80. When using spot instances, an unfulfilled request for an ASG with zero nodes never times out and blocks cluster autoscale for all other ASGs. We want to use the new mixed ASGs, because they do actually timeout gracefully. AFAICT they require at least two instance types to be specified, and we are more than fine using instance types that differ only on disk and/or bandwidth (with same CPU and memory) to accomplish this. |
I'm running into this issue in one cluster with an ig with 0 nodes, set it to 1 instances minimum as a workaround. What's the progress on a more permanent solution here? (k8s 1.12 with cluster-autoscaler 1.12.6) |
@choseh @angeloskyratzakos Can you guys share some logs. Seem I didn't see issues scaling from 0.. |
@Jeffwan Hi!
And this is my Deployment
Thank You! |
Sorry.... |
Having the same issue over here:
|
@choseh Do you use node selector in this case? Does your ASG has tags? |
#2248 We cherry-pick to version 1.14+ and will release it next week |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
This has been released. Feel free to reopen if there's any issues /close |
@Jeffwan: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bumps [sigs.k8s.io/jobset](https://github.com/kubernetes-sigs/jobset) from 0.3.1 to 0.3.2. - [Release notes](https://github.com/kubernetes-sigs/jobset/releases) - [Changelog](https://github.com/kubernetes-sigs/jobset/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/jobset@v0.3.1...v0.3.2) --- updated-dependencies: - dependency-name: sigs.k8s.io/jobset dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I have several ASG with current size 0. All of the ASG are created with Launch Template. I'm using gcr.io/google-containers/cluster-autoscaler:v1.3.7 with the command:
And somehow it is detecting them as Launch Configuration but it is not. How can I tell autoscaler to look for Launch Template on all ASG instead of Launch Configuration?
This are some logs:
The text was updated successfully, but these errors were encountered: