Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom AWS region overrides #1707

Closed
mbach04 opened this issue Feb 21, 2019 · 4 comments
Closed

Allow custom AWS region overrides #1707

mbach04 opened this issue Feb 21, 2019 · 4 comments
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider

Comments

@mbach04
Copy link

mbach04 commented Feb 21, 2019

Unique regional endpoints exist in disconnected AWS environments. Currently the aws-go-sdk that is utilized heavily in k8s hard codes these regions in json [1] and doesn't appear to expose an easy method to override that would flow down to a repo like the k8s/autoscaler. A similar issue [2] with a merged PR [3] was filed against the k8s repo.

The previous solution was to read a file that specified the custom endpoints and associated services. This is something that would benefit those same environments tremendously and all for the use of the auto-scaler. I'm happy to take a crack at this patch, but it's taking me a while to find the right place in this repo to inject the reading of such a file or env var.

Because the hostnames and certs for these custom regions are private, they will never see the light of day in the aws-go-sdk models json file defining all available services. Being able to override these hostnames dynamically would be extremely helpful.

  1. AWS endpoints models
  2. RFE Allow to override default AWS endpoint
  3. Add AWS Custom Endpoint capability #70588
@aleksandra-malinowska aleksandra-malinowska added area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider labels Feb 21, 2019
@aleksandra-malinowska
Copy link
Contributor

find the right place in this repo to inject the reading of such a file or env var

Anywhere in cluster-autoscaler/cloudprovider/aws/ is fair game, I suppose. If you meant it more specifically (i.e. where in that module), I'm not sure.

@mbach04 mbach04 mentioned this issue Feb 21, 2019
Closed
@cuppett
Copy link
Contributor

cuppett commented Feb 21, 2019

cc @jottofar

@jottofar
Copy link

@mbach04 I've been working on this change as well. See my code changes in #1717. I have not tested them but wanted to get them out here for review.

@mbach04
Copy link
Author

mbach04 commented Feb 24, 2019

@jottofar Awesome, do we want to close this RFE then? Also, I should be able to test this coming Monday / Tuesday.

@cuppett cuppett mentioned this issue Feb 24, 2019
Closed
@jottofar jottofar mentioned this issue Mar 3, 2019
Merged
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 5, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
7cf083f 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager snd aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 5, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
5b5cad8 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager snd aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 5, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
af9f264 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager snd aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 5, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
1b4a286 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager snd aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 6, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
036ecf6 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager snd aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 6, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
c359b8f 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager snd aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 7, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
c9832b8 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager snd aws_manager_test similar to kubernetes aws and aws_test.
k8s-ci-robot added a commit that referenced this issue Mar 12, 2019
@k8s-ci-robot
Merge pull request #1745 from jottofar/issue1707
e79fbee 
Allow custom AWS region overrides #1707
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 15, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
69088e2 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager snd aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 15, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
0f197d4 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager snd aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 15, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
f1e4d46 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager snd aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 18, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
d1abc87 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager snd aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 18, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
efc6677 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager and aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 18, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
18aed33 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager and aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 18, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
18244c1 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager and aws_manager_test similar to kubernetes aws and aws_test.
jottofar pushed a commit to jottofar/autoscaler that referenced this issue Mar 18, 2019
@ampsingram @jottofar
Allow custom AWS region overrides kubernetes#1707
e0c38f2 
Replicated changes from kubernetes "Add AWS Custom Endpoint capability #70588" into cluster-autoscaler:

- Modified aws_manager and aws_manager_test similar to kubernetes aws and aws_test.
yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this issue Feb 22, 2024
@trasc
[kueue] Check certificates readiness before the webhook server. (kube…
f39f9c7 
…rnetes#1707)

* [kueue] Check certificates readiness before the webhook server.

* Don't keep the caller busy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow custom AWS region overrides #1707 jottofar/autoscaler
4 participants
@cuppett @aleksandra-malinowska @mbach04 @jottofar