Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-autoscaler/aws: Unable to get instance type #1647

Closed
koooge opened this issue Feb 2, 2019 · 4 comments
Closed

cluster-autoscaler/aws: Unable to get instance type #1647

koooge opened this issue Feb 2, 2019 · 4 comments
Assignees
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider

Comments

@koooge
Copy link
Contributor

koooge commented Feb 2, 2019

Hi there ✋
I tried to set new ASG's launch template option to "Combine purchase options and instances". But it failed to scale up due to the missing instance type. Isn't this option supported yet?

E0202 02:39:04.817953       1 utils.go:274] Unable to build proper template node for foo-bar: Unable to get instance type from launch config or launch template
E0202 02:39:04.817967       1 static_autoscaler.go:312] Failed to scale up: failed to build node infos for node groups: Unable to get instance type from launch config or launch template

https://aws.amazon.com/about-aws/whats-new/2018/11/scale-instances-across-purchase-options-in-a-single-ASG/?nc1=h_ls

@Jeffwan
Copy link
Contributor

Jeffwan commented Feb 3, 2019

This is not supported yet. We need to consider price model for long time at this moment since the way fleet abstract is different from the nodegroup abstract in the past.

Fleet support OnDemand/ Spot and different node flavors in one node group. Currenctly, ca use node group to differentiate node flavors.

In this case, CA does support multi node groups, If you want to use that way, please just create one ASG for one type of node. As I know, user create one for OnDemand and one for Spot. Enable scaling down to 0 for Spot ASG and always keep few nodes for OnDemand.

Please track status on following issues and probably just close this one. Thanks!
aws/containers-roadmap#144
#838

@Jeffwan
Copy link
Contributor

Jeffwan commented Feb 3, 2019

/assign @Jeffwan

@bskiba bskiba added area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider labels Feb 4, 2019
@bskiba
Copy link
Member

bskiba commented Feb 4, 2019

Closing in favour of the issues mentioned by @Jeffwan. Thanks!
/close

@k8s-ci-robot
Copy link
Contributor

@bskiba: Closing this issue.

In response to this:

Closing in favour of the issues mentioned by @Jeffwan. Thanks!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider
Projects
None yet
Development

No branches or pull requests

4 participants