Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide PricingModel for AWS #131

Closed
mwielgus opened this issue Jun 20, 2017 · 14 comments
Closed

Provide PricingModel for AWS #131

mwielgus opened this issue Jun 20, 2017 · 14 comments
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mwielgus
Copy link
Contributor

Follow up of #82

cc: @mumoshu
@mwielgus mwielgus added area/provider/aws Issues or PRs related to aws provider area/cluster-autoscaler help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 20, 2017
@mwielgus mwielgus mentioned this issue Jun 22, 2017
Closed
@andrewsykim andrewsykim mentioned this issue Sep 16, 2017
Closed
@mrcrgl
Copy link

mrcrgl commented Nov 7, 2017

We're interested in this feature. Are contributions welcome?

@mwielgus
Copy link
Contributor Author

mwielgus commented Nov 7, 2017

@mrcrgl Absolutely, please send us a PR.

@mrcrgl
Copy link

mrcrgl commented Nov 16, 2017

@mwielgus Ok. I'll start on it. Is it fine for you guys to evaluate the spot prices on demand via the spot price history api? I also tend to load the price list on demand as well (with caching).

@kylegato
Copy link

@mrcrgl It looks like some of the work for the on-demand pricing was started here:

https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/ec2_instance_types/gen.go

Because pricing can be dependent on your region and account features, this seems to cover some of that, but it needs to be fixed to work with the current API response formats.

Support for detecting the GPU field and instance types would also be nice for that.

I think getting the spot prices from the spot price history API makes perfect sense.

mrcrgl added a commit to mrcrgl/autoscaler that referenced this issue Nov 22, 2017
@mrcrgl
Added OnDemand and Spot Price models addressing kubernetes#131
1e548ee
@mrcrgl
Copy link

mrcrgl commented Nov 22, 2017

I've worked on it. I'll test these feature within the next few days on one of our clusters.
Does this change work for you guys?

@mrcrgl mrcrgl mentioned this issue Nov 23, 2017
Closed
@mrcrgl
Copy link

mrcrgl commented Dec 1, 2017

@mwielgus PTAL #486

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 1, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 31, 2018
@patrickf55places
Copy link

The lifecycle/rotten label should be removed; the PR is still active.

@aleksandra-malinowska
Copy link
Contributor

/remove-lifecycle stale

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@bskiba
Copy link
Member

bskiba commented Jun 21, 2018

/reopen

@k8s-ci-robot
Copy link
Contributor

@bskiba: you can't re-open an issue/PR unless you authored it or you are assigned to it.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elmiko pushed a commit to elmiko/kubernetes-autoscaler that referenced this issue Mar 16, 2020
@openshift-merge-robot
Merge pull request kubernetes#131 from joelsmith/crypto-up
3098f41 
UPSTREAM: 2872: VPA: Update golang.org/x/crypto
@kesor
Copy link

kesor commented Sep 23, 2020

@mwielgus @mumoshu can you reopen this? or if this has been implemented, link the issue that has this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@kesor @kylegato @mrcrgl @bskiba @aleksandra-malinowska @mwielgus @k8s-ci-robot @patrickf55places @fejta-bot