Merge pull request #2096 from frobware/fix-segv-in-updateReadinessStats

Fix potential SEGV in updateReadinessStats
kubernetes · Jun 11, 2019 · dd89fb1 · dd89fb1
2 parents c4fc0d8 + 91016a6
commit dd89fb1
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/cluster-autoscaler/clusterstate/clusterstate.go b/cluster-autoscaler/clusterstate/clusterstate.go
@@ -585,6 +585,10 @@ func (csr *ClusterStateRegistry) updateReadinessStats(currentTime time.Time) {
 			klog.Warningf("Failed to get nodegroup for %s: %v", unregistered.Node.Name, errNg)
 			continue
 		}
+		if nodeGroup == nil {
+			klog.Warningf("Nodegroup is nil for %s", unregistered.Node.Name)
+			continue
+		}
 		perNgCopy := perNodeGroup[nodeGroup.Id()]
 		if unregistered.UnregisteredSince.Add(csr.config.MaxNodeProvisionTime).Before(currentTime) {
 			perNgCopy.LongUnregistered++