Merge pull request #5210 from antonkurbatov/bugfix/magnum-tls-insecure

magnum: add an option to create insecure TLS connections
kubernetes · Oct 5, 2022 · c65a3a3 · c65a3a3
2 parents ddf0fe0 + 4491403
commit c65a3a3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/cluster-autoscaler/cloudprovider/magnum/magnum_openstack_clients.go b/cluster-autoscaler/cloudprovider/magnum/magnum_openstack_clients.go
@@ -108,6 +108,7 @@ type Config struct {
 		DomainName      string `gcfg:"domain-name"`
 		Region          string
 		CAFile          string `gcfg:"ca-file"`
+		TLSInsecure     string `gcfg:"tls-insecure"`
 		SecretName      string `gcfg:"secret-name"`
 		SecretNamespace string `gcfg:"secret-namespace"`
 	}
@@ -169,15 +170,16 @@ func createProviderClient(cfg *Config, opts config.AutoscalingOptions) (*gopherc
 
 	klog.V(5).Infof("Using user-agent %q", userAgent.Join())
 
+	config := &tls.Config{}
+	config.InsecureSkipVerify = cfg.Global.TLSInsecure == "true"
 	if cfg.Global.CAFile != "" {
 		roots, err := certutil.NewPool(cfg.Global.CAFile)
 		if err != nil {
 			return nil, err
 		}
-		config := &tls.Config{}
 		config.RootCAs = roots
-		provider.HTTPClient.Transport = netutil.SetOldTransportDefaults(&http.Transport{TLSClientConfig: config})
 	}
+	provider.HTTPClient.Transport = netutil.SetOldTransportDefaults(&http.Transport{TLSClientConfig: config})
 
 	err = openstack.AuthenticateV3(provider, authOpts, gophercloud.EndpointOpts{})
 	if err != nil {