Merge pull request #2138 from emailksravi/master

Validation to verify if node.Spec.ProviderID is nil - for GCE

cluster-autoscaler/cloudprovider/gce/gce_cloud_provider.go

@@ -96,6 +96,7 @@ func (gce *GceCloudProvider) NodeGroups() []cloudprovider.NodeGroup {
 func (gce *GceCloudProvider) NodeGroupForNode(node *apiv1.Node) (cloudprovider.NodeGroup, error) {
 	ref, err := GceRefFromProviderId(node.Spec.ProviderID)
 	if err != nil {
+		klog.Errorf("Error extracting node.Spec.ProviderID for node %v: %v", node.Name, err)
 		return nil, err
 	}
 	mig, err := gce.gceManager.GetMigForInstance(ref)
@@ -158,6 +159,10 @@ func (ref GceRef) ToProviderId() string {
 // gce://<project-id>/<zone>/<name>
 // TODO(piosz): add better check whether the id is correct
 func GceRefFromProviderId(id string) (GceRef, error) {
+	if len(id) == 0 {
+		return GceRef{}, fmt.Errorf("wrong id: expected format gce://<project-id>/<zone>/<name>, got nil")
+	}
+
 	splitted := strings.Split(id[6:], "/")
 	if len(splitted) != 3 {
 		return GceRef{}, fmt.Errorf("wrong id: expected format gce://<project-id>/<zone>/<name>, got %v", id)