Compare in overflow-safe way

kubernetes · Aug 24, 2018 · 796b24f · 796b24f
1 parent 6e9f520
commit 796b24f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator.go b/vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator.go
@@ -157,8 +157,8 @@ func (calc *UpdatePriorityCalculator) getUpdatePriority(pod *apiv1.Pod, recommen
 				if recommended.MilliValue() > request.MilliValue() {
 					scaleUp = true
 				}
-				if (hasLowerBound && request.MilliValue() < lowerBound.MilliValue()) ||
-					(hasUpperBound && request.MilliValue() > upperBound.MilliValue()) {
+				if (hasLowerBound && request.Cmp(lowerBound) < 0) ||
+					(hasUpperBound && request.Cmp(upperBound) > 0) {
 					outsideRecommendedRange = true
 				}
 			} else {