Merge pull request #1736 from bskiba/fix-registration

Fix nil reference in admission controller registration.
kubernetes · Feb 27, 2019 · 567eac3 · 567eac3
2 parents bb2bc8c + 4519d59
commit 567eac3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/vertical-pod-autoscaler/pkg/admission-controller/config.go b/vertical-pod-autoscaler/pkg/admission-controller/config.go
@@ -67,8 +67,10 @@ func selfRegistration(clientset *kubernetes.Clientset, caCert []byte, namespace
 	}
 	RegisterClientConfig := v1beta1.WebhookClientConfig{}
 	if !registerByURL {
-		RegisterClientConfig.Service.Name = *namespace
-		RegisterClientConfig.Service.Name = "vpa-webhook"
+		RegisterClientConfig.Service = &v1beta1.ServiceReference{
+			Namespace: *namespace,
+			Name:      "vpa-webhook",
+		}
 	} else {
 		RegisterClientConfig.URL = &url
 	}