Bump xterm.js to v3.12.0 and bundle its dist #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @spadgett |
|
Hold on merging. I'm thinking I should use NPM to install xterm.js, then use grunt to copy to |
Done. Ready for review. |
in order to pick up latest bug fixes. Direct inclusion of xterm.js dist is being done since the latest versions of xterm.js are not available via Bower (xterm.js-next is not being maintained). Note: this change results in invalid meta in bower.json (`The "main" field has to contain only 1 file per filetype...`), but the net result is only a warning in Bower's output when installing. This is a small concession in order to easily keep xterm.js updated.
spadgett
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to pick up latest bug fixes.
Direct inclusion of xterm.js dist is being done since the latest versions of xterm.js are not available via Bower (xterm.js-next is not being maintained).
Note: this change results in invalid meta in bower.json (
The "main" field has to contain only 1 file per filetype...), but the net result is only a warning in Bower's output when installing. This is a small concession in order to easily keep xterm.js updated.