Upgrade xterm.js to v3.1.0 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
approved these changes
Feb 23, 2018
openshift-merge-robot
added a commit
to openshift/origin-web-console
that referenced
this pull request
Mar 1, 2018
Automatic merge from submit-queue. Bump kubernetes-container-terminal to v3.0.0 Requires kubernetes-ui/container-terminal#35   Known issues: * [Default fonts are vertically offset on some Linux distributions](xtermjs/xterm.js#1170)  * Firefox on Windows incorrectly calculates the terminal width due to padding on div.terminal.xterm 
cloudbehl
pushed a commit
to cloudbehl/origin-web-console
that referenced
this pull request
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the underlying dependency (xterm.js) is changing, I'm also bumping the version number of this package to v3.0.0.
Changes:
Known issues:
[1] https://github.com/xtermjs/xterm.js dropped Bower support with the release of v3.0.0. As a result, I'm using https://github.com/Greenek/bower-xterm.js instead as it provides the same dist with Bower support.