Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial EKS cluster creation #99

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

knabben
Copy link
Member

@knabben knabben commented Nov 26, 2023

What type of PR is this?

/label kind/documentation

What this PR does / why we need it:

  • Refactoring the cluster module to simplify the managed node groups creation on EKS and updating to Windows 2022.
  • Adding README for the Terraform EKS

Which issue(s) this PR fixes:

Fixes #98

@k8s-ci-robot
Copy link
Contributor

@knabben: The label(s) `/label kind/documentation

cannot be applied. These labels are supported:api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labelsorlabels -> restricted_labelsinplugin.yaml`?

In response to this:

What type of PR is this?

/label kind/documentation

What this PR does / why we need it:

  • Refactoring the cluster module to simplify the managed node groups creation on EKS and updating to Windows 2022.
  • Adding README for the Terraform EKS

Which issue(s) this PR fixes:

Fixes #98

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knabben

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 26, 2023
terraform/README.md Outdated Show resolved Hide resolved
@ameukam
Copy link
Member

ameukam commented Nov 26, 2023

Why are we dropping the config for the jumper ?

@knabben
Copy link
Member Author

knabben commented Nov 26, 2023

Why are we dropping the config for the jumper ?

I think I missed the jumper setup, is data "aws_ami" "ubuntu_2204" bringing the EC2 or just setting the data?

@knabben
Copy link
Member Author

knabben commented Nov 27, 2023

@marciogmorales will take over from here.

@knabben knabben merged commit 5c355f7 into kubernetes-sigs:main Nov 27, 2023
2 checks passed
@tzifudzi
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add README on terraform codebase
4 participants