Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owners: add spiffxp and nikhita as approvers #51

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Apr 1, 2021

this is intended to be temporary to assist with default branch rename
migration, but I also note the repo has a few PRs languishing that I am
willing to help move forward

we will PR ourselves out when we lack bandwidth to be responsive

while I was here I also added the sig/contributor-experience label to
auto-label PRs to this repo

/assign @jeefy

this is intended to be temporary to assist with default branch rename
migration, but I also note the repo has a few PRs languishing that I am
willing to help move forward

we will PR ourselves out when we lack bandwidth to be responsive

while I was here I also added the sig/contributor-experience label to
auto-label PRs to this repo
@k8s-ci-robot k8s-ci-robot requested review from cpanato and jeefy April 1, 2021 15:31
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2021
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2021
@nikhita
Copy link
Member

nikhita commented Apr 1, 2021

/lgtm

@jeefy
Copy link
Member

jeefy commented Apr 1, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, jeefy, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0cd003f into kubernetes-sigs:master Apr 1, 2021
@spiffxp spiffxp deleted the update-root-owners branch April 1, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants