fixes #5, add a finalizer to fix deletion during pv protection

[rmb938]

#5

[rmb938]

It seems the tests are failing on getting the test-pod. Not sure what's going on any ideas?

[wongma7]

thanks for figuring out the issue and this patch, don't worry about the test I am looking into it

[wongma7]

@rmb938 the finalizer name needs changing
"I1221 20:56:35.169970 1 controller.go:1075] provision "default/hostpath-pvc" class "example-hostpath": failed to save persistentvolume "pvc-da7cac17-0562-11e9-b559-b2cbe663ac83": PersistentVolume "pvc-da7cac17-0562-11e9-b559-b2cbe663ac83" is invalid: metadata.finalizers[0]: Invalid value: "external-provisioner.volume.kubernetes.io": name is neither a standard finalizer name nor is it fully qualified"

How it worked locally for me, I have no idea!

[rmb938]

Huh strange...

It seems finalizers have changed in 1.13 to have the syntax of label names. So I'll have to change it to something like external-provisioner.volume.kubernetes.io/finalizer

[wongma7]

/lgtm
/approve
thanks again & happy holidays.

feel free to squash if you like, I will re-add lgtm.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmb938, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rmb938]

@wongma7 Squashed and rebased to latest master. What is the process on getting another release? I would like to update https://github.com/kubernetes-csi/external-provisioner to get this change incorporated.

[rmb938]

@wongma7 Could we get this merged and released?

[wongma7]

/lgtm
yes, sorry for the delay, a release will be tagged today