Fix RemoveFinalizer methods in svcat cli

[mszostok]

Description

Fix method for removing the service-catalog finalizer from the ServiceInstance and ServiceBinding.

Context:
In the previous approach (Aggregate API server) the UpdateStatus func allowed to update fields under metadata entry. When we switch to the native webhook concept, this hacky implementation was removed and now we should use the Update function as the UpdateStatus modifies only Status entry.

/kind bug

[mszostok]

/retest

[MHBauer]

/lgtm

[jberkhahn]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkhahn, mszostok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/svcat/OWNERS [jberkhahn,mszostok]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jberkhahn]

/retest

[jberkhahn]

/retest

[fabstu]

Hello @mszostok, I hit the same issue here. I only saw this PR after I created a patch of my own, but with tests added already. :)

If UpdateStatus is called then the actions' SubResource is "status". The following expression checks for that. Just add it at the end of the Finalizer tests RemoveFinalizerForBinding and RemoveFinalizerForInstance:

    Expect(actions[1].(testing.UpdateActionImpl).GetSubresource()).To(Equal(""))

[mszostok]

/retest

[mszostok]

/test pull-build-all-images-for-amd64

[mszostok]

/test pull-build-all-images-for-ppc64le