Fix intermittent issue with E2E tests #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libseccomp-static package only exists from alpine v3.13 onwards. The base image 1.15.7-alpine uses that alpine branch.
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, pjbgf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The
libseccomp-staticpackage only exists from alpinev3.13onwards, but the initialgolang:1.15-alpinetag usedv3.12and later on updated tov3.13. The base imagegolang:1.15.7-alpineuses that alpine branch.Here's my locally cached
golang:1.15-alpineand the new image:After removing
golang:1.15-alpinelocally and trying again the result is different:Therefore it looks like when the e2e works successfuly is because it has a fresher version of the
golang:1.15-alpinetag.Yet another reason to love mutable tags. 😄
Which issue(s) this PR fixes:
None
Does this PR have test?
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?