Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: update chart repo to https://kubernetes-sigs.github.io/secrets-store-csi-driver/charts #695

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 19, 2021

Signed-off-by: Anish Ramasekar [email protected]

What this PR does / why we need it:

  • The helm charts have been moved to https://kuberentes-sigs.github.io/secrets-store-csi-driver/charts. With this PR, we're updating the install and upgrade instructions to use the new helm chart repository URL.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ritazh and tam7t August 19, 2021 16:58
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2021
@nilekhc
Copy link
Contributor

nilekhc commented Aug 19, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2021
@@ -10,14 +10,31 @@ Quick start instructions for the setup and configuration of secrets-store-csi-dr

### Installing the chart

Add the chart repo
> Note: The helm chart repository URL has changed from `https://raw.githubusercontent.com/kuberentes-sigs/secrets-store-csi-driver/master/charts` to `https://kuberentes-sigs.github.io/secrets-store-csi-driver/charts`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think it may be fine to remove this note from all the first time install pages and only leave it on the upgrade one, it may 'get in the way' of new users who have to read it and determine whether it matters to them or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same, but only concern is what if they have the repo added before and plan to install it now. They might reference the doc for the configuration parameters and see the note to change the URL? wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that makes sense, maybe we have a bug for like 3-6 months to just remove this note just so we dont keep it around forever

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm! Issue: #699

@aramase
Copy link
Member Author

aramase commented Aug 19, 2021

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2021
@aramase
Copy link
Member Author

aramase commented Aug 20, 2021

/test pull-secrets-store-csi-driver-e2e-vault

@tam7t
Copy link
Contributor

tam7t commented Aug 21, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2021
@ritazh
Copy link
Member

ritazh commented Aug 23, 2021

Let's make sure the release notes include a big warning that the helm chart repo has moved.

@aramase
Copy link
Member Author

aramase commented Aug 23, 2021

Let's make sure the release notes include a big warning that the helm chart repo has moved.

sounds good! Thanks, Rita!

@aramase
Copy link
Member Author

aramase commented Aug 23, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2021
@aramase
Copy link
Member Author

aramase commented Aug 23, 2021

/test pull-secrets-store-csi-driver-e2e-windows

@k8s-ci-robot k8s-ci-robot merged commit db1c56f into kubernetes-sigs:master Aug 23, 2021
@aramase aramase deleted the update-helm-repo branch August 23, 2021 18:07
@fableforester
Copy link

@aramase
The new URL (https://kuberentes-sigs.github.io/secrets-store-csi-driver/charts) is not available and leads into a 404 Not Found. We are currently unable to get the driver running.

@aramase
Copy link
Member Author

aramase commented Aug 26, 2021

@fableforester I just tried and the url works fine:

➜ helm repo rm secrets-store-csi-driver
"secrets-store-csi-driver" has been removed from your repositories

~
➜ helm repo add secrets-store-csi-driver https://kubernetes-sigs.github.io/secrets-store-csi-driver/charts
"secrets-store-csi-driver" has been added to your repositories

@fableforester
Copy link

@aramase
Weird, must have been a temporary unavailability yesterday. The command is working now, sorry!

@mikestef9
Copy link

Typo in docs "kuberentes" instead of "kubernetes"

@nilekhc nilekhc mentioned this pull request Sep 1, 2021
@nilekhc
Copy link
Contributor

nilekhc commented Sep 1, 2021

Typo in docs "kuberentes" instead of "kubernetes"

@mikestef9 Good catch! Thanks. Created a PR to fix this.

@tam7t Could you please update release notes?

@aramase
Copy link
Member Author

aramase commented Sep 1, 2021

@mikestef9 Thanks for reporting the issue.

@tam7t Could you please update release notes?

The typo has been fixed in the release notes.

@aramase aramase changed the title helm: update chart repo to https://kuberentes-sigs.github.io/secrets-store-csi-driver/charts helm: update chart repo to https://kubernetes-sigs.github.io/secrets-store-csi-driver/charts Sep 2, 2021
@aramase aramase mentioned this pull request Sep 2, 2021
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants