-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: update chart repo to https://kubernetes-sigs.github.io/secrets-store-csi-driver/charts
#695
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6906f7f
to
35a6a01
Compare
/lgtm |
@@ -10,14 +10,31 @@ Quick start instructions for the setup and configuration of secrets-store-csi-dr | |||
|
|||
### Installing the chart | |||
|
|||
Add the chart repo | |||
> Note: The helm chart repository URL has changed from `https://raw.githubusercontent.com/kuberentes-sigs/secrets-store-csi-driver/master/charts` to `https://kuberentes-sigs.github.io/secrets-store-csi-driver/charts`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think it may be fine to remove this note from all the first time install pages and only leave it on the upgrade one, it may 'get in the way' of new users who have to read it and determine whether it matters to them or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking the same, but only concern is what if they have the repo added before and plan to install it now. They might reference the doc for the configuration parameters and see the note to change the URL? wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that makes sense, maybe we have a bug for like 3-6 months to just remove this note just so we dont keep it around forever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm! Issue: #699
/retest |
…-store-csi-driver/charts` Signed-off-by: Anish Ramasekar <[email protected]>
35a6a01
to
b268f75
Compare
/test pull-secrets-store-csi-driver-e2e-vault |
/lgtm |
Let's make sure the release notes include a big warning that the helm chart repo has moved. |
sounds good! Thanks, Rita! |
/hold cancel |
/test pull-secrets-store-csi-driver-e2e-windows |
@aramase |
@fableforester I just tried and the url works fine: ➜ helm repo rm secrets-store-csi-driver
"secrets-store-csi-driver" has been removed from your repositories
~
➜ helm repo add secrets-store-csi-driver https://kubernetes-sigs.github.io/secrets-store-csi-driver/charts
"secrets-store-csi-driver" has been added to your repositories |
@aramase |
Typo in docs "kuberentes" instead of "kubernetes" |
@mikestef9 Good catch! Thanks. Created a PR to fix this. @tam7t Could you please update release notes? |
@mikestef9 Thanks for reporting the issue.
The typo has been fixed in the release notes. |
https://kuberentes-sigs.github.io/secrets-store-csi-driver/charts
https://kubernetes-sigs.github.io/secrets-store-csi-driver/charts
Signed-off-by: Anish Ramasekar [email protected]
What this PR does / why we need it:
https://kuberentes-sigs.github.io/secrets-store-csi-driver/charts
. With this PR, we're updating the install and upgrade instructions to use the new helm chart repository URL.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: