Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: migrate azure jobs to eks prow cluster #1578

Merged
merged 1 commit into from
Jul 26, 2024
Merged

ci: migrate azure jobs to eks prow cluster #1578

merged 1 commit into from
Jul 26, 2024

Conversation

aramase
Copy link
Member

@aramase aramase commented Jul 22, 2024

  • Migrate azure jobs to eks prow cluster

part of #1273

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2024
@aramase aramase force-pushed the aramase/t/migrate_azure_jobs branch 9 times, most recently from f4e2103 to 2051fc4 Compare July 23, 2024 04:06
@aramase
Copy link
Member Author

aramase commented Jul 23, 2024

/test pull-secrets-store-csi-driver-e2e-windows-prow-migration-test

@aramase aramase self-assigned this Jul 23, 2024
@k8s-ci-robot

This comment was marked as resolved.

Sign in to view
@aramase aramase force-pushed the aramase/t/migrate_azure_jobs branch 5 times, most recently from a241fbf to 4624f0b Compare July 26, 2024 18:01
@aramase
Copy link
Member Author

aramase commented Jul 26, 2024

/test pull-secrets-store-csi-driver-e2e-azure-prow-migration-test

@aramase aramase force-pushed the aramase/t/migrate_azure_jobs branch from 4624f0b to bbed807 Compare July 26, 2024 18:33
@aramase
Copy link
Member Author

aramase commented Jul 26, 2024

/test pull-secrets-store-csi-driver-e2e-azure-prow-migration-test
/test pull-secrets-store-csi-driver-e2e-windows-prow-migration-test

@aramase aramase mentioned this pull request Jul 26, 2024
Merged
@aramase aramase force-pushed the aramase/t/migrate_azure_jobs branch from bbed807 to 812dd10 Compare July 26, 2024 19:03
@aramase
Copy link
Member Author

aramase commented Jul 26, 2024

/test pull-secrets-store-csi-driver-e2e-azure-prow-migration-test /test pull-secrets-store-csi-driver-e2e-windows-prow-migration-test

Tests passed:

aramase
aramase commented Jul 26, 2024
View reviewed changes
Makefile
ALL_OSVERSIONS.windows := 1809 ltsc2022
ALL_OS_ARCH.windows = $(foreach arch, $(ALL_ARCH.windows), $(foreach osversion, ${ALL_OSVERSIONS.windows}, windows-${osversion}-${arch}))
ALL_OS_ARCH = $(foreach os, $(ALL_OS), ${ALL_OS_ARCH.${os}})
ALL_ARCH_linux ?= amd64 arm64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using . in the variable name makes it hard to reference variables in shell, so using _ consistently.

aramase
aramase commented Jul 26, 2024
View reviewed changes
test/bats/azure.bats
export SECRET_NAME=${KEYVAULT_SECRET_NAME:-secret1}
export SECRET_VERSION=${KEYVAULT_SECRET_VERSION:-""}
export SECRET_VALUE=${KEYVAULT_SECRET_VALUE:-"test"}
export KEY_NAME=${KEYVAULT_KEY_NAME:-key1}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trimmed down the azure provider tests because the goal is to have small set of tests for providers. These key specific tests are done in the e2e-provider test suite.

aramase
aramase commented Jul 26, 2024
View reviewed changes
test/bats/azure.bats
@@ -310,66 +258,14 @@ setup() {
assert_success
}

@test "Test auto rotation of mount contents and K8s secrets - Create deployment" {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rotation is tested as part of e2e-provider suite and doesn't need to be done again in azure provider

aramase
aramase commented Jul 26, 2024
View reviewed changes
test/bats/tests/azure/rotation/azure_synck8s_v1_secretproviderclass.yaml Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder has been deleted because we don't test rotation in azure provider (tested as part of e2e-provider already)

@aramase aramase force-pushed the aramase/t/migrate_azure_jobs branch from 812dd10 to 96d6e56 Compare July 26, 2024 19:13
@aramase aramase marked this pull request as ready for review July 26, 2024 20:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tam7t July 26, 2024 20:20
@aramase aramase force-pushed the aramase/t/migrate_azure_jobs branch from 96d6e56 to a1b1949 Compare July 26, 2024 20:21
@aramase aramase force-pushed the aramase/t/migrate_azure_jobs branch from a1b1949 to 1bfd728 Compare July 26, 2024 20:35
nilekhc
nilekhc reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@nilekhc nilekhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit. Otherwise lgtm

test/scripts/run-e2e-azure.sh Show resolved Hide resolved
@aramase aramase requested a review from nilekhc July 26, 2024 21:14
@nilekhc
Copy link
Contributor

nilekhc commented Jul 26, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit a30bc3c into kubernetes-sigs:main Jul 26, 2024
26 checks passed
@aramase aramase deleted the aramase/t/migrate_azure_jobs branch July 26, 2024 21:22
@aramase aramase mentioned this pull request Aug 2, 2024
Merged
k8s-ci-robot added a commit that referenced this pull request Aug 9, 2024
@k8s-ci-robot
Merge pull request #1591 from aramase/automated-cherry-pick-of-#1578-…
cef2865 
…upstream-release-1.4

Automated cherry pick of #1578: ci: migrate azure job to eks prow cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritazh ritazh Awaiting requested review from ritazh

@tam7t tam7t Awaiting requested review from tam7t

@nilekhc nilekhc Awaiting requested review from nilekhc

Assignees

@nilekhc nilekhc

@aramase aramase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aramase @k8s-ci-robot @nilekhc