-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charts: Fix imagePullSecrets #1560
base: main
Are you sure you want to change the base?
Conversation
This PR fixes `imagePullSecrets` rendering did not work as expected, the diff between the bug revision and the fixed revision is shown below: diff -y bad.yml good.yml (with some identical sections removed for simplicity) --- --- kind: DaemonSet kind: DaemonSet apiVersion: apps/v1 apiVersion: apps/v1 spec: spec: template: template: spec: spec: serviceAccountName: secrets-store-csi-driver serviceAccountName: secrets-store-csi-driver imagePullSecrets: imagePullSecrets: - ps1 | - name: ps1 affinity: affinity: nodeAffinity: nodeAffinity: requiredDuringSchedulingIgnoredDuringExecution: requiredDuringSchedulingIgnoredDuringExecution: nodeSelectorTerms: nodeSelectorTerms: - matchExpressions: - matchExpressions: - key: type - key: type operator: NotIn operator: NotIn values: values: - virtual-kubelet - virtual-kubelet --- --- apiVersion: batch/v1 apiVersion: batch/v1 kind: Job kind: Job spec: spec: template: template: spec: spec: serviceAccountName: release-name-secrets-store-csi- serviceAccountName: release-name-secrets-store-csi- imagePullSecrets: imagePullSecrets: - ps1 | - name: ps1 restartPolicy: Never restartPolicy: Never containers: containers: - name: crds-upgrade - name: crds-upgrade image: "hiltoncn-registry-vpc.cn-shanghai.cr.aliy image: "hiltoncn-registry-vpc.cn-shanghai.cr.aliy args: args: - apply - apply - -f - -f - crds/ - crds/ imagePullPolicy: IfNotPresent imagePullPolicy: IfNotPresent nodeSelector: nodeSelector: kubernetes.io/os: linux kubernetes.io/os: linux tolerations: tolerations: - operator: Exists - operator: Exists --- --- apiVersion: batch/v1 apiVersion: batch/v1 kind: Job kind: Job spec: spec: template: template: spec: spec: serviceAccountName: release-name-secrets-store-csi- serviceAccountName: release-name-secrets-store-csi- imagePullSecrets: imagePullSecrets: - ps1 | - name: ps1 restartPolicy: Never restartPolicy: Never nodeSelector: nodeSelector: kubernetes.io/os: linux kubernetes.io/os: linux tolerations: tolerations: - operator: Exists - operator: Exists The fixup is a port from hashicorp/vault helm charts when I'm setting up csi driver with vault provider. The hashicorp/vault charts work well, but csi driver charts works bad. So it's quite obvious that the fixup is out there. hashicorp/vault-helm@64b4d88 Signed-off-by: Park Zhou <[email protected]>
Welcome @ideapark! |
Hi @ideapark. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ideapark The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes
imagePullSecrets
rendering did not work as expected,the diff between the bug revision and the fixed revision is shown
below:
The fixup is a port from hashicorp/vault helm charts when I'm setting
up csi driver with vault provider. The hashicorp/vault charts work
well, but csi driver charts works bad. So it's quite obvious that the
fixup is out there.
hashicorp/vault-helm@64b4d88
Signed-off-by: Park Zhou [email protected]