Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use kubectl v1.26.0 in driver-crds #1111

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Dec 9, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • use kubectl v1.26.0 in driver-crds
  • reenable trivy scan for binaries in driver-crds

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1075

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from nilekhc and tam7t December 9, 2022 19:00
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2022
@aramase
Copy link
Member Author

aramase commented Dec 9, 2022

/retitle chore: use kubectl v1.26.0 in driver-crds

@k8s-ci-robot k8s-ci-robot changed the title Driver crds v1.26 chore: use kubectl v1.26.0 in driver-crds Dec 9, 2022
@tam7t
Copy link
Contributor

tam7t commented Dec 9, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
@aramase
Copy link
Member Author

aramase commented Dec 9, 2022

/test pull-secrets-store-csi-driver-e2e-provider-k8s-1-26-0

@k8s-ci-robot k8s-ci-robot merged commit 2a72276 into kubernetes-sigs:main Dec 9, 2022
@aramase aramase deleted the driver-crds-v1.26 branch December 9, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to v1.26.x in driver-crds image
3 participants