nfd-master: update node if no NodeFeature objects are present #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/assign @fmuyassarov @ArangoGutierrez |
k8s-ci-robot
added
the
size/M
marquiz
force-pushed
the
fixes/nodefeature-missing
branch
2 times, most recently
from
6868e94 to
80e697d
Compare
fmuyassarov
reviewed
Dec 17, 2022
No it's not a dumb question. But yes it does, I might want to change the wording a bit, though |
k8s-ci-robot
added
the
do-not-merge/hold
marquiz
force-pushed
the
fixes/nodefeature-missing
branch
from
80e697d to
8e87645
Compare
|
Improved the commit message |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
changed the title
|
@fmuyassarov PTAL. Makes sense(?) |
Correctly handle the case where no NodeFeature objects exist for certain node (and NodeFeature API has been enabled with -enable-nodefeature-api). In this case all the labels should be removed.
marquiz
force-pushed
the
fixes/nodefeature-missing
branch
from
8e87645 to
4c955ad
Compare
fmuyassarov
reviewed
Dec 19, 2022
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c7adefb3e69773eec624c9e8fa92cb7f17a1742e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handle the case where no NodeFeature objects exist for certain
node (and NodeFeature API has been enabled with
-enable-nodefeature-api). In this case all the labels should be removed.